Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5774 : Add YaRD #5775

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

5774 : Add YaRD #5775

wants to merge 4 commits into from
+2,958 −0

Conversation

Rikkola
Copy link
Contributor

@Rikkola Rikkola commented Mar 7, 2024 •
edited
Loading

#5774

Some thoughts, questions and notes:

  • This PR does not make YaRD a Kie Resource, should it?
  • Currently only "scripting" language supported is JShell. It is plain Java so not that "scripty", should we use MVEL or even FEEL?
  • Reason for treblereel YAML Mapper is the need to use the same YaRD API on the client side. This mapper works on both Java and JavaScript/J2CL
  • For Decision Tables. Hit policies FIRST, COLLECT and ANY are implemented. Each one of them does one run on the data and returns another set of data. Compared to the other Drools dtables the behaviour is different ( but not wrong ). Later we might want to add table modes that allow editing the inputs and repassing them to the table, like the older Drools dtables do.
  • Inputs can have a schema as a type. However that is not tested, but using an object as an input and accessing the fields might still work, who knows.
  • No expression support inside the Decision Tables, if we move to use MVEL this might come for free if Rule Unit DSL supports this
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.

  • for a full downstream build

    • for github actions job: add the label run_fdb

  • for Jenkins PR check only

@Rikkola Rikkola requested a review from lucamolteni March 7, 2024 09:43
@Rikkola Rikkola force-pushed the YaRD branch 3 times, most recently from 68a2a40 to 9edd3f1 Compare April 10, 2024 13:08
@Rikkola Rikkola force-pushed the YaRD branch 2 times, most recently from 648cfa2 to 6341bdb Compare April 29, 2024 09:14
@Rikkola Rikkola linked an issue Jun 3, 2024 that may be closed by this pull request
Add YaRD ( Yet Another Rule Definition ) #5774
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucamolteni lucamolteni Awaiting requested review from lucamolteni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add YaRD ( Yet Another Rule Definition )
1 participant
@Rikkola